feat: make audio output into button and improve weather exit process

src/AudioOutput.qml

@@ -10,7 +10,7 @@ import "base"
 // - adjust sink & source volume
 // - mute sinks & sources
 
-BRectangle {
+BButton {
     id: audiow
     height: (icon.height + slider.height) * 1.5
 
@@ -20,68 +20,61 @@ BRectangle {
         objects: [audiow.sink]
     }
 
-    AudioManager {
+    property AudioManager audioman: AudioManager {}
-        id: audioman
+
+    onClicked: {
+        audioman.visible = !audioman.visible;
     }
 
-    MouseArea {
+    onWheel: wheel => {
-        id: audio_area
+        const newVal = audiow.sink.audio.volume + (wheel.angleDelta.y / 12000);
+        audiow.sink.audio.volume = newVal < 1.0 ? (newVal > 0 ? newVal : 0.0) : 1.0;
+    }
 
-        anchors.fill: parent
+    Rectangle {
+        width: parent.width
+        color: "transparent"
 
-        onClicked: {
+        height: icon.height + slider.height
-            audioman.visible = !audioman.visible;
+        anchors.verticalCenter: parent.verticalCenter
+
+        // TODO: Make icon depend on sink type and volume level
+        Image {
+            id: icon
+            source: "root:/assets/speaker.png"
+            width: parent.width * (2 / 3)
+
+            anchors.horizontalCenter: parent.horizontalCenter
+            fillMode: Image.PreserveAspectFit
         }
 
-        onWheel: wheel => {
+        Slider {
-            const newVal = audiow.sink.audio.volume + (wheel.angleDelta.y / 12000);
+            id: slider
-            audiow.sink.audio.volume = newVal < 1.0 ? (newVal > 0 ? newVal : 0.0) : 1.0;
+            anchors.top: icon.bottom
-        }
+            anchors.horizontalCenter: parent.horizontalCenter
+            height: background.height
+            width: parent.width * 0.75
 
-        Rectangle {
+            enabled: false
-            width: parent.width
+            value: audiow.sink?.audio.volume ?? 0
-            color: "transparent"
+            stepSize: 0.01
 
-            height: icon.height + slider.height
+            contentItem: Rectangle {
-            anchors.verticalCenter: parent.verticalCenter
+                color: "#3191CD" // Change color based on value
-
+                radius: 5
-            // TODO: Make icon depend on sink type and volume level
+                width: slider.width * (slider.value / slider.to)
-            Image {
+                height: parent.height
-                id: icon
-                source: "root:/assets/speaker.png"
-                width: parent.width * (2 / 3)
-
-                anchors.horizontalCenter: parent.horizontalCenter
-                fillMode: Image.PreserveAspectFit
             }
 
-            Slider {
+            background: Rectangle {
-                id: slider
+                color: "#C4C4C4"
-                anchors.top: icon.bottom
+                radius: 5
-                anchors.horizontalCenter: parent.horizontalCenter
+                height: 4
-                height: background.height
+                anchors.bottomMargin: 5
-                width: parent.width * 0.75
+                anchors.topMargin: 5
-                enabled: false
-                value: audiow.sink?.audio.volume ?? 0
-                stepSize: 0.01
-
-                contentItem: Rectangle {
-                    color: "#3191CD" // Change color based on value
-                    radius: 5
-                    width: slider.width * (slider.value / slider.to)
-                    height: parent.height
-                }
-
-                background: Rectangle {
-                    color: "#C4C4C4"
-                    radius: 5
-                    height: 4
-                    anchors.bottomMargin: 5
-                    anchors.topMargin: 5
-                }
-
-                handle: Rectangle {}
             }
+
+            handle: Rectangle {}
         }
     }
 }

src/MainBar.qml

@@ -45,7 +45,10 @@ PanelWindow {
             // TODO: on click open a calendar view
             ClockWidget {}
 
-            AudioOutput {}
+            AudioOutput {
+                width: parent.width
+                height: parent.width * 1.2
+            }
 
             SysTray {}
 

src/Nysh.qml

@@ -13,7 +13,7 @@ Item {
 
     Component.onCompleted: {
         I3.focusedMonitorChanged.connect(e => {
-            dash.focused = I3.monitorFor(root.screen)?.focused;
+            dash.focused = I3.monitorFor(root.screen)?.focused ?? false;
         });
     }
 

src/provider/Weather.qml

@@ -57,13 +57,9 @@ Singleton {
                 weather.dataRaw += e;
             }
         }
-        onRunningChanged: {
+        onExited: (code, status) => {
-            if (running) {
+            weather.lastFetch = JSON.parse(weather.dataRaw);
-                weather.dataRaw = "";
+            weather.dataRaw = "";
-            }
-            if (!running) {
-                weather.lastFetch = JSON.parse(weather.dataRaw);
-            }
         }
     }