chore: apply lsp suggestions and indicator for primary sink

src/widgets/battery/Battery.qml

@@ -1,4 +1,4 @@
-import "root:base"
+import "../../base"
 import Quickshell.Services.UPower
 import QtQuick
 import QtQuick.Layouts

src/widgets/privacy/Privacy.qml

@@ -1,4 +1,4 @@
-import "root:base"
+import "../../base"
 import QtQuick.Layouts
 
 BRectangle {

src/widgets/systray/SysTray.qml

@@ -3,7 +3,7 @@ import QtQuick.Layouts
 import QtQuick.Controls
 import Quickshell
 import Quickshell.Services.SystemTray
-import "root:base"
+import "../../base"
 
 BRectangle {
     height: 112

src/widgets/workspaces/WorkspaceElem.qml

@@ -4,7 +4,7 @@ import QtQuick
 import QtQuick.Layouts
 
 Rectangle {
-    id: elem
+    id: root
 
     required property bool focused
     required property int wnum
@@ -27,11 +27,11 @@ Rectangle {
         hoverEnabled: true
 
         onEntered: () => {
-            elem.hovered = true;
+            root.hovered = true;
         }
 
         onExited: () => {
-            elem.hovered = false;
+            root.hovered = false;
         }
         onClicked: () => {
             switcher.running = true;
@@ -40,14 +40,14 @@ Rectangle {
 
     Process {
         id: switcher
-        command: ["swaymsg", "workspace", `${wnum}`]
+        command: ["swaymsg", "workspace", `${root.wnum}`]
     }
 
     states: State {
         name: "focused"
-        when: active
+        when: root.active
         PropertyChanges {
-            target: elem
+            target: root
             Layout.rightMargin: activeMargin
             Layout.leftMargin: activeMargin
         }

src/widgets/workspaces/WorkspaceIPC.qml

@@ -2,33 +2,33 @@ import QtQuick
 import Quickshell.Io
 
 Item {
+    id: root
+
     property int active: 1 // currently active workspace
     property int amount: 10 // amount of workspaces
     property string name: "" // name of the current desktop
 
     Process {
-        property string name: ""
-
         command: ["env"]
         running: true
 
         stdout: SplitParser {
             onRead: data => {
                 if (data.startsWith("XDG_CURRENT_DESKTOP="))
-                    name = data.slice(20);
+                    root.name = data.slice(20);
             }
         }
     }
 
     Process {
         command: ["swaymsg", "-mtsubscribe", "[\"workspace\"]"]
-        running: name === "sway"
+        running: root.name === "sway"
 
         stdout: SplitParser {
             onRead: data => {
                 const parsed = JSON.parse(data);
                 if (parsed.change == "focus") {
-                    active = parsed.current.num;
+                    root.active = parsed.current.num;
                 }
             }
         }

src/widgets/workspaces/Workspaces.qml

@@ -1,10 +1,11 @@
-import Quickshell
+pragma ComponentBehavior: Bound
+
 import QtQuick
 import QtQuick.Layouts
-import Quickshell.Io // for Process
+import "../../base"
-import "root:base"
 
 BRectangle {
+    id: root
     height: 100 + layout.spacing * (workspace.amount - 1)
 
     WorkspaceIPC {

src/windows/audioman/AudioEntry.qml

@@ -2,20 +2,20 @@ import QtQuick
 import QtQuick.Layouts
 import QtQuick.Controls
 import Quickshell.Services.Pipewire
-import Quickshell
 
 RowLayout {
+    id: root
     required property PwNode node
 
     // bind the node so we can read its properties
     PwObjectTracker {
-        objects: [node]
+        objects: [root.node]
     }
 
     Image {
         source: {
             const getFallback = () => node.isStream ? "root:/../assets/folder-music.svg" : "root:/../assets/audio-volume-high.svg";
-            node.properties["application.icon-name"] ? `image://icon/${node.properties["application.icon-name"]}` : getFallback();
+            root.node.properties["application.icon-name"] ? `image://icon/${root.node.properties["application.icon-name"]}` : getFallback();
         }
 
         fillMode: Image.PreserveAspectFit
@@ -37,8 +37,8 @@ RowLayout {
             Label {
                 id: name
                 text: {
-                    const app = node.isStream ? `[${node.properties["application.name"]}] ` : "";
+                    const app = root.node.isStream ? `[${root.node.properties["application.name"]}] ` : "";
-                    return app + (node.properties["media.name"] ?? node.description);
+                    return app + (root.node.properties["media.name"] ?? root.node.description);
                 }
                 // Cede space to other elements -> don't have stupidly long names detroying the layout
                 Layout.maximumWidth: 0
@@ -50,7 +50,7 @@ RowLayout {
             }
 
             Button {
-                visible: node.isSink
+                visible: root.node.isSink
                 width: 10
                 checkable: true
                 Image {
@@ -61,25 +61,27 @@ RowLayout {
 
                     fillMode: Image.PreserveAspectFit
                 }
-                onClicked: node.audio.muted = !node.audio.muted
+                onClicked: root.node.audio.muted = !root.node.audio.muted
             }
 
             Button {
-                // TODO: setting a default sink is not implemented yet in QS
+                property bool isDefault: root.node.id === Pipewire.defaultAudioSink.id
-                visible: node.isSink
+                checked: isDefault
-                text: "default"
+                checkable: false
+                visible: root.node.isSink
+                text: isDefault ? "default" : "not default"
             }
         }
         RowLayout {
             Label {
                 Layout.preferredWidth: 50
-                text: `${Math.floor(node.audio.volume * 100)}%`
+                text: `${Math.floor(root.node.audio.volume * 100)}%`
             }
 
             Slider {
                 Layout.fillWidth: true
-                value: node.audio.volume
+                value: root.node.audio.volume
-                onValueChanged: node.audio.volume = value
+                onValueChanged: root.node.audio.volume = value
             }
         }
     }